askrobots / dbbasic-object-server
Public
Runs live, versioned Python application objects on one VM, with a suite of apps: projects, notes, tasks, files and more.
danq9
signup: the person chooses the password and name on the confirm page
83c7aa6
2 weeks, 5 days ago
History
test_object_namespace_overrides.py · 6.6 KB · 171 lines
| 1 | """Override-object resolution (Phase 3, docs/upgrade-and-customization.md Rule 2). |
| 2 | |
| 3 | Overrides are strictly opt-in via DBBASIC_OVERRIDES_DIR. The single most |
| 4 | important guarantee in this module is the backward-compat guard: with the |
| 5 | env var unset, get_object_roots() must be byte-identical to the pre-override |
| 6 | behavior (get_base_object_roots()), and resolution must be unchanged. |
| 7 | """ |
| 8 | |
| 9 | from pathlib import Path |
| 10 | |
| 11 | import object_namespace |
| 12 | import object_source |
| 13 | |
| 14 | |
| 15 | def write_object(path: Path): |
| 16 | path.parent.mkdir(parents=True, exist_ok=True) |
| 17 | path.write_text("def GET(request):\n return {'status': 'ok'}\n") |
| 18 | return path |
| 19 | |
| 20 | |
| 21 | def _clear_env(monkeypatch): |
| 22 | monkeypatch.delenv("DBBASIC_OBJECTS_DIR", raising=False) |
| 23 | monkeypatch.delenv("DBBASIC_OVERRIDES_DIR", raising=False) |
| 24 | |
| 25 | |
| 26 | # --- Backward-compat guard: env unset behaves exactly as before ------------- |
| 27 | |
| 28 | |
| 29 | def test_default_env_unset_get_object_roots_matches_base_roots(monkeypatch): |
| 30 | _clear_env(monkeypatch) |
| 31 | |
| 32 | assert object_namespace.get_object_roots() == object_namespace.get_base_object_roots() |
| 33 | assert object_namespace.get_object_roots() == [Path("objects")] |
| 34 | |
| 35 | |
| 36 | def test_default_env_unset_override_root_is_none(monkeypatch): |
| 37 | _clear_env(monkeypatch) |
| 38 | |
| 39 | assert object_namespace.get_override_root() is None |
| 40 | |
| 41 | |
| 42 | def test_default_env_unset_has_override_is_false(monkeypatch): |
| 43 | _clear_env(monkeypatch) |
| 44 | |
| 45 | assert object_namespace.has_override("basics_counter") is False |
| 46 | assert object_namespace.override_path("basics_counter") is None |
| 47 | |
| 48 | |
| 49 | def test_default_env_unset_resolve_object_id_unchanged(tmp_path, monkeypatch): |
| 50 | _clear_env(monkeypatch) |
| 51 | root = tmp_path / "objects" |
| 52 | expected = write_object(root / "basics" / "counter.py") |
| 53 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(root)) |
| 54 | |
| 55 | assert object_namespace.resolve_object_id("basics_counter") == expected |
| 56 | assert object_namespace.get_object_roots() == [root] |
| 57 | |
| 58 | |
| 59 | # --- Override root enabled --------------------------------------------------- |
| 60 | |
| 61 | |
| 62 | def test_override_root_sees_env_var(tmp_path, monkeypatch): |
| 63 | override_root = tmp_path / "overrides" |
| 64 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 65 | |
| 66 | assert object_namespace.get_override_root() == override_root |
| 67 | |
| 68 | |
| 69 | def test_get_object_roots_prepends_override_to_base(tmp_path, monkeypatch): |
| 70 | base_root = tmp_path / "objects" |
| 71 | override_root = tmp_path / "overrides" |
| 72 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(base_root)) |
| 73 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 74 | |
| 75 | assert object_namespace.get_object_roots() == [override_root, base_root] |
| 76 | assert object_namespace.get_base_object_roots() == [base_root] |
| 77 | |
| 78 | |
| 79 | def test_override_relative_path_forms(monkeypatch): |
| 80 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", "/tmp/overrides-not-used") |
| 81 | |
| 82 | assert object_namespace.override_relative_path("basics_counter") == Path("basics") / "counter.py" |
| 83 | assert object_namespace.override_relative_path("dashboard") == Path("dashboard.py") |
| 84 | # User objects are not supported by overrides. |
| 85 | assert object_namespace.override_relative_path("u_42_deals") is None |
| 86 | # Invalid ids are rejected outright. |
| 87 | assert object_namespace.override_relative_path("../escape") is None |
| 88 | |
| 89 | |
| 90 | def test_override_path_and_has_override(tmp_path, monkeypatch): |
| 91 | override_root = tmp_path / "overrides" |
| 92 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 93 | |
| 94 | expected = override_root / "basics" / "counter.py" |
| 95 | assert object_namespace.override_path("basics_counter") == expected |
| 96 | assert object_namespace.has_override("basics_counter") is False |
| 97 | |
| 98 | write_object(expected) |
| 99 | assert object_namespace.has_override("basics_counter") is True |
| 100 | |
| 101 | |
| 102 | def test_override_path_none_for_user_object(tmp_path, monkeypatch): |
| 103 | override_root = tmp_path / "overrides" |
| 104 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 105 | |
| 106 | assert object_namespace.override_path("u_42_deals") is None |
| 107 | assert object_namespace.has_override("u_42_deals") is False |
| 108 | |
| 109 | |
| 110 | def test_resolve_object_id_prefers_override_when_present(tmp_path, monkeypatch): |
| 111 | base_root = tmp_path / "objects" |
| 112 | override_root = tmp_path / "overrides" |
| 113 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(base_root)) |
| 114 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 115 | |
| 116 | base_path = write_object(base_root / "basics" / "counter.py") |
| 117 | override_path = override_root / "basics" / "counter.py" |
| 118 | override_path.parent.mkdir(parents=True, exist_ok=True) |
| 119 | override_path.write_text("def GET(request):\n return {'status': 'overridden'}\n") |
| 120 | |
| 121 | resolved = object_namespace.resolve_object_id("basics_counter") |
| 122 | |
| 123 | assert resolved == override_path |
| 124 | assert resolved != base_path |
| 125 | |
| 126 | |
| 127 | def test_resolve_object_id_falls_back_to_base_when_no_override_file(tmp_path, monkeypatch): |
| 128 | base_root = tmp_path / "objects" |
| 129 | override_root = tmp_path / "overrides" |
| 130 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(base_root)) |
| 131 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 132 | |
| 133 | base_path = write_object(base_root / "basics" / "counter.py") |
| 134 | |
| 135 | assert object_namespace.resolve_object_id("basics_counter") == base_path |
| 136 | |
| 137 | |
| 138 | def test_get_object_source_reads_override_but_base_roots_read_package_copy(tmp_path, monkeypatch): |
| 139 | base_root = tmp_path / "objects" |
| 140 | override_root = tmp_path / "overrides" |
| 141 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(base_root)) |
| 142 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 143 | |
| 144 | write_object(base_root / "basics" / "counter.py") |
| 145 | override_file = override_root / "basics" / "counter.py" |
| 146 | override_file.parent.mkdir(parents=True, exist_ok=True) |
| 147 | override_file.write_text("def GET(request):\n return {'status': 'overridden'}\n") |
| 148 | |
| 149 | # Default (override-aware) resolution reads the override. |
| 150 | assert object_namespace.resolve_object_id("basics_counter") == override_file |
| 151 | assert "overridden" in object_source.get_object_source("basics_counter") |
| 152 | |
| 153 | # Explicitly scoping to base roots always reads the pristine package copy. |
| 154 | base_only = object_source.get_object_source("basics_counter", object_namespace.get_base_object_roots()) |
| 155 | assert "overridden" not in base_only |
| 156 | assert "'status': 'ok'" in base_only |
| 157 | |
| 158 | |
| 159 | def test_iter_object_sources_marks_override_kind(tmp_path, monkeypatch): |
| 160 | base_root = tmp_path / "objects" |
| 161 | override_root = tmp_path / "overrides" |
| 162 | monkeypatch.setenv("DBBASIC_OBJECTS_DIR", str(base_root)) |
| 163 | monkeypatch.setenv("DBBASIC_OVERRIDES_DIR", str(override_root)) |
| 164 | |
| 165 | write_object(base_root / "basics" / "counter.py") |
| 166 | write_object(override_root / "dashboard.py") |
| 167 | |
| 168 | sources = {source.object_id: source.kind for source in object_namespace.iter_object_sources()} |
| 169 | |
| 170 | assert sources["basics_counter"] == "system" |
| 171 | assert sources["dashboard"] == "override" |