Runs live, versioned Python application objects on one VM, with a suite of apps: projects, notes, tasks, files and more.

0 downloads

dbbasic-object-server/tests/test_app_orders_detail_retrofit.py
Download zip
Clone
Clone with git
git clone https://gitstable.com/git/askrobots/dbbasic-object-server.git
HTTPS
https://gitstable.com/git/askrobots/dbbasic-object-server.git
SSH
ssh://git@gitstable.com:2222/askrobots/dbbasic-object-server.git

Cloning needs no sign-in. Pushing over HTTPS asks for your username and an access token. SSH needs your key under SSH keys.

danq9 signup: the person chooses the password and name on the confirm page 83c7aa6 2 weeks, 5 days ago History
test_app_orders_detail_retrofit.py · 5.6 KB · 136 lines
1"""Stage-6 retrofit of packages/app-orders: the bespoke site_order_view.py
2page is replaced by a seeded 59 detail view composed of three GENERIC block
3renderers -- an editable+deletable `detail` block (the order; money renders
4via /form's cents formatting, no custom JS, and status transitions become
5status-field edits in the owner's edit form, guarded by the schema's own
610-flow transitions -- not one-click buttons, the same make-it-basic trade
7app-forum's pin/lock takes), a `related` block (order_lines flat by
8order_id -- order_lines stays a RELATIONAL collection, not embedded, so a
9line remains individually addressable), and a `form` block with a FK
10locked to the page's order (Add Line). Owner-only throughout: the
11row-filtered collection API only ever returns real data to the order's
12owner, same as the page it replaces.
13"""
14
15import json
16from pathlib import Path
17
18import object_packages
19import object_permissions
20
21PACKAGES_ROOT = Path(__file__).resolve().parents[1] / "packages"
22APP_ORDERS_DIR = PACKAGES_ROOT / "app-orders"
23
24
25def _seed_rows(name):
26 import csv
27
28 with open(APP_ORDERS_DIR / "seed" / f"{name}.tsv", newline="") as fh:
29 return list(csv.DictReader(fh, delimiter="\t"))
30
31
32def test_manifest_drops_bespoke_order_view_page_and_seeds_the_detail_view():
33 package = object_packages.get_package("app-orders", root=PACKAGES_ROOT)
34 # 0.3.0 deletes the bespoke /orders list page object too -- see
35 # tests/test_app_orders_package.py.
36 assert {obj["id"] for obj in package["objects"]} == {
37 "system_order_totals",
38 # 0.4.0: the pick queue as a number, for the attention band.
39 "system_order_attention",
40 # 0.5.0: the store-voice slice -- token minting, the public
41 # /orders/track/{token} page, and the three customer emails.
42 "system_order_portal_link",
43 "system_order_email",
44 "site_order_status",
45 # 0.6.0: the drop-ship slice -- the action that raises the
46 # vendor's purchase order from a sale order, and the two-row
47 # margin read that proved margin needed no stored field.
48 "action_dropship_order",
49 "site_dropship_margin",
50 }
51 assert {entry["collection"] for entry in package["seed"]} == {
52 "orders", "order_lines", "views", "site_routes",
53 }
54 assert {dep["id"] for dep in package["dependencies"]} == {"app-views"}
55
56
57def test_order_view_object_file_is_deleted():
58 assert not (APP_ORDERS_DIR / "objects" / "site" / "order_view.py").exists()
59
60
61def test_order_view_composes_detail_related_and_fk_locked_form():
62 rows = _seed_rows("views")
63 # 0.3.0 added the /orders index view alongside this detail view, so
64 # assert on the detail row rather than a total that keeps growing.
65 rows = [r for r in rows if r["id"] == "view_order_detail"]
66 assert len(rows) == 1
67 view = rows[0]
68 assert view["id"] == "view_order_detail"
69 assert view["route"] == "/orders/{order_id}"
70 blocks = json.loads(view["blocks"])
71 kinds = [b["kind"] for b in blocks]
72 assert kinds == ["detail", "related", "form"]
73
74 detail, related, form = blocks
75
76 # 1. editable+deletable order detail
77 assert detail["collection"] == "orders"
78 assert detail["record_id"] == "$record_id"
79 assert detail["editable"] is True and detail["deletable"] is True
80 assert detail["delete_redirect"] == "/orders"
81
82 # 2. FLAT order_lines (a plain related list by order_id -- relational,
83 # not embedded, so a line stays individually addressable)
84 assert related["collection"] == "order_lines"
85 assert related["fk_field"] == "order_id"
86 assert related["match"] == "$record_id"
87 assert related["title"] == "Line Items"
88
89 # 3. add-line form with order_id locked to the page's order
90 assert form["collection"] == "order_lines"
91 assert form["fixed"] == {"order_id": "$record_id"}
92 assert form["title"] == "Add Line"
93
94
95def test_permalink_route_points_to_view_render():
96 rows = _seed_rows("site_routes")
97 # 0.3.0 appended the /orders index route, so assert on the detail row
98 # rather than a total that keeps growing.
99 rows = [r for r in rows if r["id"] == "route_order_detail"]
100 assert len(rows) == 1
101 assert rows[0]["pattern"] == "/orders/{order_id}"
102 assert rows[0]["object_id"] == "site_view_render"
103
104
105def test_permissions_no_longer_reference_the_removed_object():
106 payload = json.loads((APP_ORDERS_DIR / "permissions" / "rules.json").read_text())
107 object_ids = {rule.get("object_id") for rule in payload["rules"]}
108 assert "site_order_view" not in object_ids
109 assert "site_orders" in object_ids
110
111
112def test_no_public_read_survives_the_retrofit():
113 """Orders and order_lines stay owner-private: the retrofit must not
114 have added a public read rule on either collection, and the removed
115 object's public-execute rule must be gone too (already covered
116 above)."""
117 payload = json.loads((APP_ORDERS_DIR / "permissions" / "rules.json").read_text())
118 policy = object_permissions.policy_from_dict(
119 {"access_mode": "role_based", "rules": payload["rules"]}
120 )
121 for collection in ("orders", "order_lines"):
122 decision = object_permissions.check_permission(
123 None, object_permissions.READ, policy=policy, collection=collection,
124 record={"owner_id": "7"},
125 )
126 assert decision.allowed is False, f"anonymous read should be denied on {collection}"
127
128
129def test_dry_run_is_safe(tmp_path):
130 object_root = tmp_path / "objects"
131 object_root.mkdir()
132 plan = object_packages.dry_run_package(
133 "app-orders", root=PACKAGES_ROOT, base_dir=tmp_path / "data", object_roots=[object_root],
134 )
135 assert plan["safe_to_install"] is True
136 assert plan["warnings"] == []